OriginProtocol / OriginProtocol/origin-dollar

Clear up confusion on swap routes

Open
#1,684 0 comments 0 reactions 1 assignee View on GitHub

@matt-bullock is already working on this.

Since Jul 6, 2023.

dapp enhancement frontend P2 ui/ux
Dominant language
Solidity
Stars
152
Forks
115
Avg merge
3d 20h
Merged PRs (30d)
17

Description

There have been several questions from different people about what the "effective price" is supposed to mean on each swap route. I'm realizing now though that the "after fees" text is confusing. In this example, I don't know what fees it is referring to. Apparently, gas is not part of the equation because $18.85 is the value shown on ETH, OETH, and the bottom line. The gas costs alone in this case are likely to be greater than this amount.

Screenshot 2023-07-06 at 1 43 40 PM

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.