OriginProtocol / OriginProtocol/origin-dollar

OGV Governance Fork test improvement

Open
#1,549 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P2
Dominant language
Solidity
Stars
152
Forks
115
Avg merge
3d 20h
Merged PRs (30d)
17

Description

With the implementation of Oracle Router's recency checks on Oracle prices, our fork test environment no longer processes fork network blocks & time for the amounts configured on the mainnet to pass proposals. We have rather modified the deploy scripts to shorten the proposal voting and queue times.

But this doesn't solve all the issues. Currently, there is a problem with the 060 deploy. The proposal has been submitted on the mainnet and queued. The deploy scripts rightly shorten the voting and queue time on the contract but the proposal has already been queued on the mainnet before the queue time has been shortened on the forked environment that bases off of the mainnet.

Possible solutions:

  1. find a hackish way by modifying storage slots to change the queue time of an active proposal
  2. cancel queued proposal and re-submit it, vote for it and queue & execute it
  3. alter Oracle router so that on the forked network the data can be stale and tests will pass. -> can't really test oracle data recency then

I'd vote for option 2.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the fork test environment and deploy scripts, then reproduce the 060 deployment against the queued mainnet proposal. Compare the three proposed approaches and verify that the chosen approach lets fork governance proposals complete while preserving Oracle Router recency checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
solidity
Domain
blockchain, testing
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.