OriginProtocol / OriginProtocol/origin-dollar
Vault generalisation
Nobody has claimed this yet.
- Dominant language
- Solidity
- Stars
- 152
- Forks
- 115
- Avg merge
- 3d 20h
- Merged PRs (30d)
- 17
Description
As part of the OpenZeppelin audit report the OZ team has suggested we could do a better job with Vault generalisation:
I have started a draft PR https://github.com/OriginProtocol/origin-dollar/pull/1519 and came pretty quickly to a realisation that this is not going to be a small task and we also need to be quite cognisant of which contract's external functions get renames and what possible contract / dapp / analytics re-deploys that will trigger.
In the long run it would be still cool we address this issue as to no cause too much technical debt with improper naming.
One thing is sure, that this is not a high priority task and IMHO we should get to it when we have more breathing room.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the OpenZeppelin audit recommendation and draft PR #1519. Map which contract external functions would be renamed and assess the stated contract, dapp, and analytics redeployment impacts; done requires an agreed generalisation plan that avoids breaking downstream consumers.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- solidity
- Domain
- blockchain
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100