OriginProtocol / OriginProtocol/origin-dollar
Revisit OUST/OETH tests at 18vs27
Open
Nobody has claimed this yet.
contracts
P1
security
- Dominant language
- Solidity
- Stars
- 152
- Forks
- 115
- Avg merge
- 3d 20h
- Merged PRs (30d)
- 17
Description
In the past we've had our unit tests run at 1e18 resolution to expose rounding behaviors. We changed it to 1e27 to hide these errors, and act more like the real contract in tests. We should think which way we want to go here for sure.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the OUST and OETH unit tests and comparing their 1e18 and 1e27 resolution behavior. Done means the project has decided which resolution should be used and the tests consistently reflect that choice.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- solidity
- Domain
- blockchain, testing
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100