OriginProtocol / OriginProtocol/origin-dollar
Confusing approval button labels
Nobody has claimed this yet.
- Dominant language
- Solidity
- Stars
- 152
- Forks
- 115
- Avg merge
- 3d 20h
- Merged PRs (30d)
- 17
Description
As a user, I often think of allowance approvals in terms of the token. However, what's being approved is the contract that needs to move the token in question. For this reason, we label the approval buttons with the contract names (e.g. "Approved Curve").
When approving the WOETH contract to move OETH, it's confusing.
"Approved WOETH"
We should change this one or consider improving all of them to be more intuitive. As I recall, we originally planned to include the word contract but it was too long in some cases.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue does not name files, tests, or an entry point. Start by locating the approval button labels for WOETH and OETH, then inspect how contract names are presented in the approval flow. Done means the confusing "Approved WOETH" wording is replaced with an agreed, more intuitive label, with related labels considered as described.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- solidity
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100