OriginProtocol / OriginProtocol/origin-dollar
Clean up usage of fixtures and optimize unit tests
Open
@naddison36 is already working on this.
Since Aug 8, 2023.
contracts
dependencies
devops
enhancement
good first issue
- Dominant language
- Solidity
- Stars
- 152
- Forks
- 115
- Avg merge
- 3d 20h
- Merged PRs (30d)
- 17
Description
Right now, the contracts use hardhat-deploy plugin for deployments. However, we have been wrongly using ethereum-waffle package's createFixtureLoader() method. This essentially means that right now, none of the unit/fork tests are using fixtures at all. Changing them to use hardhat-deploy packages deployments.createFixture fastens the tests by quite a significant time
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.