OrchardCMS / OrchardCMS/Orchard
DistributedSignals is not taking object content into account
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2.4k
- Forks
- 1.4k
- PR merge metrics
- No merged PRs in 30d
Description
See DistributedSignals.Trigger(): the signal object's ToString() is called, however for most objects this will simply return the class name. This causes non-string signals not to work at all as they won't be triggered on the remote nodes.
See how Distributed Events solves this by only using string signals: https://orcharddistributedevents.codeplex.com/SourceControl/latest#Services/DistributedSignals.cs
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at DistributedSignals.Trigger() and compare its signal handling with the Distributed Events implementation linked in the issue. Done means non-string signal objects use their content rather than only the class name and trigger correctly on remote nodes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- distributed-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100