Orange-OpenSource / Orange-OpenSource/ouds-android
Use switches instead of chips for tinted icons
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 22
- Forks
- 5
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 30
Description
As the tinted parameter is a boolean, it should be represented by a switch. I think we already had this discussion but I don't remember why we chose to keep filter chips.
Originally posted by @paulinea in https://github.com/Orange-OpenSource/ouds-android/pull/1468#discussion_r3801997418
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the tinted-icons implementation in the Android library and read the discussion linked from PR #1468. Check how the tinted boolean is currently exposed through filter chips, then change that control to a switch. Done means tinted icons use a switch consistently and the existing behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- design, mobile
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100