Orange-OpenSource / Orange-OpenSource/Orange-Boosted-Bootstrap

[Boosted] Scss compilation error on orange-helvetica in Angular 22

Open
#3,752 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

🐞 bug
Dominant language
CSS
Stars
219
Forks
61
Avg merge
2d 15h
Merged PRs (30d)
12

Description

Prerequisites
Describe the issue

In Angular 22 (but could be also true on previous version) we get a sass compilation error when we import orange-helvetica in the global scss file.
Angular seems to rewrite url() directive to add a || operator with a file: path, but doing so it includes a " characters, breaking the interpolation used in the orange-helvetica file for RTL fonts.

✘ [ERROR] expected "}".
   ╷
39 │   src: url("../node_modules/boosted/scss||file:#{$font-path}HelvNeue55_W1G.woff2") format("woff2") #{"/*rtl:url("../node_modules/boosted/scss||file:" + $font-path + "HelveticaNeueW20-55Roman.woff2") format('woff2')*/"};
   │                                                                                                                  ^
   ╵
  node_modules/boosted/scss/orange-helvetica.scss 39:114  @import
  src/styles.scss 3:9                                     root stylesheet [plugin angular-sass]

    angular:styles/global:styles:1:8:
      1 │ @import 'src/styles.scss';
        ╵         ~~~~~~~~~~~~~~~~~                                                                                                                                                                                                                                                                                 

Reduced test cases
  • install angular CLI globally : npm install -g @angular/cli
  • create a new angular project : ng new
  • add boosted as dependency
  • import orange-helvetica in src/styles.scss : @import "boosted/scss/orange-helvetica";
  • start the server : npm start
What operating system(s) are you seeing the problem on?

macOS

What browser(s) are you seeing the problem on?

Firefox

What version of OUDS Web are you using?

boosted 5.3.8

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure with a new Angular CLI project, the src/styles.scss import, and npm start. Then inspect node_modules/boosted/scss/orange-helvetica.scss, especially the RTL font interpolation around line 39, alongside Angular's Sass compilation output. Done means the reduced project compiles successfully with orange-helvetica imported.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, scss
Domain
build-system, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.