Orange-OpenSource / Orange-OpenSource/IOT-Map-Component

Fix some controls' rendering in Storybook

Open
#153 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug docs
Dominant language
TypeScript
Stars
24
Forks
8
PR merge metrics
No merged PRs in 30d

Description

Description

https://github.com/Orange-OpenSource/IOT-Map-Component/pull/151 was a complex PR that was getting rid of addon-knobs. In the process of doing that, something was not handled completely.

As you can see in https://orange-opensource.github.io/IOT-Map-Component/?path=/story/gauge--gauge&args=shapePercent:33, when you modify the value of shape.percent in the "Controls" tab, the value is taken into account in the view but the value doesn't change in the "Controls" view; it stays to 15/100.

In this same view, the boolean default value is not set in the "Controls" view. However, the color and number inputs work correctly.

In https://orange-opensource.github.io/IOT-Map-Component/?path=/story/gaugewithinner--gauge-with-inner, the text input in the "Controls" view doesn't change even if the value is well-changed on the map rendering side.

Same thing in https://orange-opensource.github.io/IOT-Map-Component/?path=/story/shapes--shapes where the default radio buttons values are not set.

There's an undefined issue globally in the way the "Controls" panel view is updated/synchronized.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the gauge, gauge-with-inner, and shapes stories from the linked Storybook pages, then review the control synchronization changes from PR #151. Trace why modified values and boolean or radio defaults are not reflected in the Controls view. Done means the Controls panel stays synchronized with the rendered map for these cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
storybook, typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.