OpenwaterHealth / OpenwaterHealth/openlifu-python
Add external power supply option in LIFUInterface class
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 27
- Forks
- 21
- Avg merge
- 1d 20m
- Merged PRs (30d)
- 6
Description
Separate TXDevice and HVController classes within the LIFUInterface class so that if we are using an external supply we can easily instantiate one or both. This should also allow clean up of the test scripts from having excessive if/else checks.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the LIFUInterface, TXDevice, and HVController classes, then inspect the test scripts that contain the excessive conditional checks. Done means the interface can instantiate TXDevice, HVController, either, or both for an external supply, with the test scripts simplified accordingly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- embedded-iot
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100