OpenwaterHealth / OpenwaterHealth/openlifu-python
Rename "yaw" and "pitch" in virtual fitting
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 27
- Forks
- 21
- Avg merge
- 1d 20m
- Merged PRs (30d)
- 6
Description
"yaw" and "pitch" are more appropriate for rotations from an object's point of view. In our case, we're talking about orbiting a transducer around an approximately-spherical head.
I think what we want is either "latitude - longitude", or "azimuth - elevation". I kind of like "latitude-longitude" because it mirrors coordinates on a globe, and we can simply define the "nose" position as the "equator"/"prime meridian"
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the virtual fitting implementation and all uses of “yaw” and “pitch.” Resolve whether the project will use “latitude-longitude” or “azimuth-elevation,” define the coordinate convention around the nose position, and update the affected terminology consistently once that decision is made.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100