OpenwaterHealth / OpenwaterHealth/openlifu-python

Virtual fit search grid should not be target-dependent

Open
#366 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
27
Forks
21
Avg merge
1d 20m
Merged PRs (30d)
6

Description

Currently the virtual fit search grid is defined based on a spherical coordinate system with the target as the origin.

This works, but it might be better to have the search grid positions be the same no matter where the target is located, i.e. base them on global head coordinates.


Example: This is pitch -10, 60 in increments of 5, and yaw -55, 55 in increments of 5

Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the virtual fit search-grid construction and the spherical-coordinate inputs it uses. Compare grids for different target locations using the example pitch and yaw ranges; done means the grid positions remain identical in global head coordinates regardless of the target.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.