OpenwaterHealth / OpenwaterHealth/openlifu-python
Include units in Trigger JSON
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Python
- Stars
- 27
- Forks
- 21
- Avg merge
- 1d 20m
- Merged PRs (30d)
- 6
Description
in the low-level communication to TXDevice, the field "TriggerPulseTrainInterval" is interpreted by the firmware as microseconds. This should be changed to "TriggerPulseTrainIntervalUsec" for clarity. Will require matching change in the firmware.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the low-level communication code that serializes the TriggerPulseTrainInterval field for TXDevice, then identify the matching firmware field. The change is done when the JSON field is named TriggerPulseTrainIntervalUsec consistently in the Python and firmware sides and the communication still works.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- embedded-iot
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100