OpenwaterHealth / OpenwaterHealth/openlifu-python
solution computation and analysis need more rigorous unit testing
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 27
- Forks
- 21
- Avg merge
- 1d 20m
- Merged PRs (30d)
- 6
Description
There some functions that directly affect safety and what pulse amplitudes will be requested from the transducer elements, and these need to be rigorously unit tested and verified.
Protocol.calc_solutionSoltution.analyze, particularly the mainlobe pnpSolution.scale
and any components these function use
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Protocol.calc_solution, Solution.analyze, and Solution.scale, then inspect any existing tests and the components they call. Add rigorous unit coverage for solution computation, mainlobe PNP analysis, scaling, and the resulting transducer pulse amplitudes; done means the relevant safety-sensitive behavior is verified by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100