OpenZeppelin / OpenZeppelin/openzeppelin-upgrades
Upgrade transaction is sent even if proxy is already upgraded
Open
Nobody has claimed this yet.
bug
good first issue
- Dominant language
- TypeScript
- Stars
- 658
- Forks
- 286
- PR merge metrics
- No merged PRs in 30d
Description
Running upgradeProxy twice on the same proxy with the same implementation contract sends two upgrade transactions under the hood. The second transaction should not be necessary, since the proxy is already set to the correct implementation.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the upgradeProxy entry point and the tests covering repeated upgrades. Reproduce two calls with the same proxy and implementation, then trace how the current implementation is checked. Done means the second call no longer sends an unnecessary upgrade transaction while an upgrade to a different implementation still works.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100