OpenZeppelin / OpenZeppelin/openzeppelin-upgrades
Validate proxy and proxyadmin owner before sending a transaction
Open
Nobody has claimed this yet.
good first issue
- Dominant language
- TypeScript
- Stars
- 658
- Forks
- 286
- PR merge metrics
- No merged PRs in 30d
Description
If the current sender does not own the ProxyAdmin, they get a revert with an Ownable error:
Error: Returned error: VM Exception while processing transaction: revert Ownable: caller is not the owner -- Reason given: Ownable: caller is not the owner.
As a nice to have, we could prevent this by checking if the sender is the owner of the proxyadmin before sending the tx. And since we're at it, we can also check that the proxy to upgrade is indeed owned by the proxyadmin.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is identified in the issue. Begin at the upgrade transaction entry point and trace how the sender, ProxyAdmin, and proxy are resolved; done means invalid ownership is reported before the transaction is sent, with coverage for both ownership checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain, devtools
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100