OpenZeppelin / OpenZeppelin/openzeppelin-upgrades
Remove reliance on getTransactionByHash
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 658
- Forks
- 286
- PR merge metrics
- No merged PRs in 30d
Description
We were assuming that getTransactionByHash would always work for a transaction in the chain, and we throw an error if the transaction is not found, but this appears to be wrong and eg. Geth will by default drop the index for transactions older than 1 year.
Once the transaction is finalized we don't really need to look it up by hash so we should be able to remove this reliance.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the uses of getTransactionByHash and the finalized-transaction path. Verify how missing lookups are handled for transactions older than a year, and consider the work complete when finalized transactions no longer fail because that index entry is unavailable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100