OpenZeppelin / OpenZeppelin/openzeppelin-upgrades
gasPrice is set to 0 with LedgerSigner
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 658
- Forks
- 286
- PR merge metrics
- No merged PRs in 30d
Description
Hey,
I'm trying to call upgradeProxy() with a Ledger wallet via @ethersproject/hardware-wallets but found that the transaction could not be picked up by nodes since the gas prices was setup to 0 due to some bug in @ethersproject/hardware-wallets
There's an issue in repo @ethersproject/hardware-wallets. And in it, it mentioned there's a workaround by setup an option in overrides in Etheres' call function. But the plugin does not expose such deep API.
Wondering if there's any suggested quick work around? Thank you!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the upgradeProxy() transaction path and how it invokes @ethersproject/hardware-wallets. Compare the plugin's exposed call options with the workaround described in the linked Ledger issue. Done means the LedgerSigner transaction no longer uses a gas price of 0, or the supported workaround is clearly documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100