OpenZeppelin / OpenZeppelin/openzeppelin-upgrades
Storage layout types include storage location
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 658
- Forks
- 286
- PR merge metrics
- No merged PRs in 30d
Description
For example a string storage variable will be stored with type t_string_storage. The _storage part is irrelevant as we know this is a storage variable, and in particular it's incompatible with the types extracted by the old zos CLI.
We currently have code that removes the _ptr part in _storage_ptr but we could remove _storage as well.
We need to consider backwards compatibility: upgrading from type t_string_storage to type t_string should be considered ok. The _storage part needs to be ignored.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in packages/core/src/utils/type-id.ts around line 30, where storage type identifiers are normalized. Check how _ptr is removed and extend the compatibility handling so _storage is ignored when comparing types. Done means upgrading from t_string_storage to t_string is accepted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100