OpenZeppelin / OpenZeppelin/openzeppelin-upgrades

Deduplicate testing contracts

Open
#115 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

tests
Dominant language
TypeScript
Stars
658
Forks
286
PR merge metrics
No merged PRs in 30d

Description

See /packages/plugin-buidler/test/contracts and /packages/plugin-truffle/test/contracts.

We should try to put all these in a common directory and use a symlink to reuse in both test suites.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the contract files in packages/plugin-buidler/test/contracts and packages/plugin-truffle/test/contracts, then inspect how each test suite discovers them. Move the shared contracts into a common directory and reuse them from both suites as proposed; done means both plugin test suites still run successfully without duplicated contract files.

Written by the indexing model from the issue text.

Assessment

Domain
testing
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.