OpenZeppelin / OpenZeppelin/openzeppelin-contracts
Incorrect "deadline" field description in IERC20Permit
Open
Nobody has claimed this yet.
- Dominant language
- Solidity
- Stars
- 27.2k
- Forks
- 12.4k
- Avg merge
- 2d 19h
- Merged PRs (30d)
- 33
Description
This line states that deadline must be in the future
https://github.com/OpenZeppelin/openzeppelin-contracts/blob/8b12f83a702210cdeff862c837ffb338811c31a4/contracts/token/ERC20/extensions/IERC20Permit.sol#L55
However, in fact, the current timestamp can also be used.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open contracts/token/ERC20/extensions/IERC20Permit.sol at line 55 and review the deadline description against the issue's observation about the current timestamp. Done means the text accurately describes the accepted deadline values; no test or other entry point is mentioned in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- solidity
- Domain
- blockchain, documentation
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100