OpenZeppelin / OpenZeppelin/openzeppelin-contracts
AccessControl unification discussion
Nobody has claimed this yet.
- Dominant language
- Solidity
- Stars
- 27.2k
- Forks
- 12.4k
- Avg merge
- 2d 19h
- Merged PRs (30d)
- 33
Description
🧐 Motivation
As we now have #4425 I would like to raise the question about the unification of AccessControlDefaultAdminRules and Ownable2Step
These two flows look very similar but have slightly different implementation
| Ownable2Step | AccessControlDefaultAdminRules |
|---|---|
| pendingOwner | pendingDefaultAdmin |
| N/A | pendingDefaultAdminDelay |
| N/A | defaultAdminDelayIncreaseWait |
| N/A | changeDefaultAdminDelay |
| N/A | rollbackDefaultAdminDelay |
| transferOwnership | beginDefaultAdminTransfer |
| acceptOwnership | acceptDefaultAdminTransfer |
| N/A | cancelDefaultAdminTransfer |
I want to propose to unify them
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading issue #4425 and comparing the AccessControlDefaultAdminRules and Ownable2Step flows listed here, including their pending state, transfer, acceptance, cancellation, and delay operations. The issue is a unification discussion rather than a defined task, so a completed change would first need an agreed API and behavior before implementation or tests can be identified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- solidity
- Domain
- blockchain
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100