OpenZeppelin / OpenZeppelin/openzeppelin-contracts
EIP-712 nonces unification discussion
Open
Nobody has claimed this yet.
- Dominant language
- Solidity
- Stars
- 27.2k
- Forks
- 12.4k
- Avg merge
- 2d 19h
- Merged PRs (30d)
- 33
Description
Related PR: https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3850
Current nonces() are incremental sequences per owner (signer) and they interfere for Votes and ERC20Permit:
contract Nonces {
function nonces(address owner) public view virtual returns (uint256);
}
contract ERC20Permit is Nonces {
function permit(address owner, address spender, uint value, uint deadline, uint8 v, bytes32 r, bytes32 s) external;
}
contract Votes is Nonces {
function delegateBySig(address delegatee, uint256 nonce, uint256 expiry, uint8 v, bytes32 r, bytes32 s) external;
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the related pull request 3850 and the Nonces, ERC20Permit, and Votes entry points shown in the issue. Determine the intended unified EIP-712 nonce behavior and how it should resolve the interaction between permit and delegation signatures; done requires an agreed design and corresponding compatibility expectations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- solidity
- Domain
- blockchain
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100