OpenZeppelin / OpenZeppelin/openzeppelin-contracts
Do not require internal constant to start with an underscore
Open
Nobody has claimed this yet.
- Dominant language
- Solidity
- Stars
- 27.2k
- Forks
- 12.4k
- Avg merge
- 2d 19h
- Merged PRs (30d)
- 33
Description
See this comment in #4325
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked discussion in pull request #4325, especially comment discussion_r1231323001, to understand the requirement being questioned. Trace the relevant internal-constant convention or check from that discussion, then confirm completion when internal constants no longer need to start with an underscore without breaking the existing checks or tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- solidity
- Domain
- blockchain
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100