OpenZeppelin / OpenZeppelin/openzeppelin-contracts

Use Ownable2Step for ProxyAdmin

Open
#4,351 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

idea
Dominant language
Solidity
Stars
27.2k
Forks
12.4k
Avg merge
2d 19h
Merged PRs (30d)
33

Description

ProxyAdmin is Ownable. To improve the security of the ownership transfer process, we should use Ownable2Step here.
Tha would, in conjuction with the TransparentUpgradeableProxy using immutable storage to store the address of the admin, greatly reduce the risk of accidentally losing control of the upgradeability.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the ProxyAdmin and TransparentUpgradeableProxy contract definitions and reading how ownership and the immutable admin address are handled. Compare the existing ownership-transfer behavior with Ownable2Step, then verify that ProxyAdmin uses the two-step process without weakening upgradeability control.

Written by the indexing model from the issue text.

Assessment

Tech stack
solidity
Domain
blockchain, security
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.