OpenZeppelin / OpenZeppelin/openzeppelin-contracts
Consider supporting payable ERC721's safeTransferFrom, transferFrom, and approve
Open
Nobody has claimed this yet.
contracts
feature
on hold
- Dominant language
- Solidity
- Stars
- 27.2k
- Forks
- 12.4k
- Avg merge
- 2d 19h
- Merged PRs (30d)
- 33
Description
🎉 Description
The ERC721 EIP lists:
safeTransferFrom(address, address, uint256, bytes)safeTransferFrom(address, address, uint256)transferFrom(address, address, uint256)approve(address, uint256)
as payable functions. The payable modifier should be added to these functions in ERC721Basic.sol and ERC721BasicToken.sol.
- 🐛 This is a bug report.
- 📈 This is a feature request.
💻 Environment
OpenZeppelin v1.10.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with ERC721Basic.sol and ERC721BasicToken.sol, locating safeTransferFrom, transferFrom, and approve. Compare those declarations with the ERC721 EIP signatures and confirm that all four listed functions accept payable calls in both files.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- solidity
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100