OpenZeppelin / OpenZeppelin/midnight-apps
Adding `rounding` param in `sqrt()`
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 11
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
When migrating this to the contracts lib, it might be worth adding in a `rounding` param and have two `sqrt` variants for additional flexibility. Def outside the scope of this PR though
Originally posted by @andrew-fleming in https://github.com/OpenZeppelin/midnight-dapps/pull/13#discussion_r2040452275
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating sqrt() in the contracts library and review the discussion linked from PR 13. Clarify the intended rounding parameter and the two sqrt variants before changing anything; done means the agreed API is implemented and covered by the relevant existing tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100