OpenZeppelin / OpenZeppelin/midnight-apps
Create reusable test fixture for math modules
@0xisk is already working on this.
Since Mar 3, 2026.
- Dominant language
- TypeScript
- Stars
- 11
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
Instead of copy-pasting tests across each math module, create a comprehensive fixture that can be reused with just type definition and bounds. This would reduce duplication and improve maintainability.
Note: Witnesses may be tricky to handle generically - may need special handling or configuration per module.
To make our lives easier, I think it'd be a great benefit to create one fixture and reuse it across each math module. We'd just need to define the type and possibly insert the bounds. DEFINITELY NOT A NOW THING haha an improvement for the future if you agree. That way we're not c/p the same tests, we just make one comprehensive fixture
Originally posted by @andrew-fleming in https://github.com/OpenZeppelin/midnight-apps/pull/292#discussion_r2855564922
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.