OpenZeppelin / OpenZeppelin/midnight-apps
CI improvements via using matrix
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 11
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
A possible improvement for the future might be to use a matrix strat. Something like:
(...)
strategy:
matrix:
task:
- name: compile
command: pnpm compact
timeout: 25
skip_zk: false
- name: test
command: pnpm test:contracts
timeout: 10
skip_zk: true
- name: types
command: pnpm types:contracts
timeout: 5
skip_zk: true
(...)
In my head, it reduces code duplication since the setups are the same...not sure if it's worth it though. The current flow is good as is so let's just get this merged!
Originally posted by @andrew-fleming in https://github.com/OpenZeppelin/midnight-apps/pull/270#discussion_r2714069453
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No workflow file or test is named in the issue. First locate the CI workflow that runs pnpm compact, pnpm test:contracts, and pnpm types:contracts; compare their shared setup, then verify that a matrix preserves each command, timeout, and skip_zk setting without changing the current CI behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions
- Domain
- ci-cd
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100