OpenZeppelin / OpenZeppelin/compact-contracts
dev: follow-up — resolve CodeRabbit findings on #594 (multisig)
Open
@0xisk is already working on this.
Since Jul 9, 2026.
2-low
blocking-release
enhancement
- Dominant language
- TypeScript
- Stars
- 55
- Forks
- 29
- Avg merge
- 5d 7h
- Merged PRs (30d)
- 25
Description
CodeRabbit findings from #594, to be fixed in a dedicated follow-up PR (keeping #594 a clean migration):
-
ShieldedMultiSigV2.compact:87— enforce threshold range> 0 and <= 2— link -
ShieldedMultiSigV2.compact:169— operation hash lacks per-instance domain binding (replay) — link -
ShieldedMultiSigV2.compact:262—stubVerifySignatureis fail-open (#470/#475) — link -
ProposalManager.compact:327— missing approve/revoke bookkeeping — link -
ShieldedTreasuryStateless.compact:65— link -
SignerManager.compact:66—assertThresholdMetshould fail closed on0— link -
SignerManager.test.ts:48— link -
ShieldedMultiSigV2Simulator.ts:33— use fixed-length tuples — link - 3 nitpicks — review summaries 1 / 2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.