OpenZeppelin / OpenZeppelin/compact-contracts
Followups: MultiToken refactor
Open
Nobody has claimed this yet.
1-medium
effort: 2-S
feat:token
- Dominant language
- TypeScript
- Stars
- 55
- Forks
- 29
- Avg merge
- 5d 7h
- Merged PRs (30d)
- 25
Description
- Redundant canonicalization -> https://github.com/OpenZeppelin/compact-contracts/pull/483#discussion_r3234002173
- followup: _update re-enters exported balanceOf instead of a raw helper -> https://github.com/OpenZeppelin/compact-contracts/pull/483#discussion_r3234039727
- Redundant as Uint<128> casts in _update -> https://github.com/OpenZeppelin/compact-contracts/pull/483#discussion_r3234045298
- that should mirror the circuit hasher so lets leave a comment to highlight that -> https://github.com/OpenZeppelin/compact-contracts/pull/483#discussion_r3234050778
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the four linked discussions from pull request #483 and trace the referenced MultiToken code, especially _update, balanceOf, the circuit hasher, canonicalization, and Uint<128> casts. Done means resolving each checklist item and confirming the implementation matches the decisions recorded in those discussions.
Written by the indexing model from the issue text.
Assessment
- Domain
- blockchain
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100