OpenZeppelin / OpenZeppelin/compact-contracts

Standardize Uint8Array over Buffer in private state and witness interfaces

Open
#442 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

2-low effort: 3-M
Dominant language
TypeScript
Stars
55
Forks
29
Avg merge
5d 7h
Merged PRs (30d)
25

Description

      newSK: Uint8Array,

non-blocking: Shouldn't that be just Uint8Array?

Originally posted by @0xisk in https://github.com/OpenZeppelin/compact-contracts/pull/420#discussion_r3058985282

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the private state and witness interfaces referenced by the issue, then inspect their type declarations for Buffer usage. Replace the relevant private-state and witness types with Uint8Array and verify that all affected interfaces remain consistent; done means those interfaces no longer require Buffer for these values.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.