OpenZeppelin / OpenZeppelin/compact-contracts
Standardize text encodings in tests
Open
Nobody has claimed this yet.
2-low
effort: 2-S
enhancement
- Dominant language
- TypeScript
- Stars
- 55
- Forks
- 29
- Avg merge
- 5d 7h
- Merged PRs (30d)
- 25
Description
const bDomain = encodePadded32(NULLIFIER_DOMAIN);
non-blocking: shouldn't that be also encoded by 32?
Originally posted by @0xisk in https://github.com/OpenZeppelin/compact-contracts/pull/420#discussion_r3058959339
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the test-related changes and discussion in pull request #420, especially the encoding suggestion quoted here. Trace the existing text-encoding helpers and their test usages, then confirm that the relevant test inputs use the same encoding width and that the tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100