OpenZeppelin / OpenZeppelin/compact-contracts

NonFungibleToken: Add `emitEvent` param to `_approve` signature

Open
#24 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

blocked events
Dominant language
TypeScript
Stars
55
Forks
29
Avg merge
5d 7h
Merged PRs (30d)
25

Description

Depends on the implementation of events in Compact

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the Compact event implementation that this issue depends on, then locate the NonFungibleToken _approve signature. Determine how the emitEvent parameter should interact with that event support; done means the signature and its callers are updated consistently once the dependency is available.

Written by the indexing model from the issue text.

Assessment

Domain
blockchain
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.