Get rid of Loki
Open
Nobody has claimed this yet.
Code Quality
External (3rd party)
Help wanted
Portability
- Dominant language
- C++
- Stars
- 3.6k
- Forks
- 536
- Avg merge
- 6d 1h
- Merged PRs (30d)
- 3
Description
Loki is a C++ library found in the sdk folder. There are several reasons to remove it:
- Most of the stuff of this library, written for C++98 by Andrei Alexandrescu, can be found in C++11, e.g. Loki::Select is just std::conditional, Loki::IsSameType can be replaced with std::is_same.
Some of the code does not compile in GCC.(With some changes, it compiled in GCC)- The things that haven't been included in modern C++, can be rewritten with fewer lines of code.
- It's barely used.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by auditing the sdk folder and searching the repository for Loki references to determine which parts are actually used. Replace or remove those uses with the C++11 equivalents described in the issue, then verify that no Loki dependency remains and the project still builds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100