OpenXRay / OpenXRay/xray-16

Sun mask in DX10 & 11

Open
#16 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Enhancement Environment (Weather) Player Experience Renderer
Dominant language
C++
Stars
3.6k
Forks
536
Avg merge
6d 1h
Merged PRs (30d)
3

Description

Apparently USE_SUNMASK in config.h or config_defines.h does not work in DX10&11 (after deleting the shaders_cache of course). I'm pretty sure it works fine in DX9 though.

Anyway, it would be nice if we could get it working properly for 10&11. The error it spits out is the typical "your video card doesn't support this, blah blah blah" shader error.

Cromm Cruac, of Atmosfear 3 fame, also suggested not just to universally get this working without having to modify the shaders each time we want to use it.
That last part I know how to do, I just don't know what causes the issue with 10&11.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the DX10/DX11 failure after deleting the shaders_cache, then trace how USE_SUNMASK is handled through config.h and config_defines.h and the relevant shader path. Done means the sun mask works in DX10 and DX11 without per-use shader edits or the unsupported-video-card shader error.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics, game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.