OpenVoiceOS / OpenVoiceOS/wallpaper_changer

EGLFS

Open
#3 0 comments 0 reactions 3 assignees View on GitHub

@NeonDaniel is already working on this.

Since Mar 27, 2024.

bug
Dominant language
Python
Stars
1
Forks
3
No merged PRs in 30d

Description

from https://github.com/OpenVoiceOS/ovos-PHAL-plugin-wallpaper-manager/issues/7

the plugin works around this, but this package should also handle this better

Mar 27 16:17:34 neon ovos_PHAL[2219]: exception calling callback for <Future at 0x7f9cadead0 state=finished raised TypeError>
Mar 27 16:17:34 neon ovos_PHAL[2219]: Traceback (most recent call last):
Mar 27 16:17:34 neon ovos_PHAL[2219]:   File "/usr/lib/python3.11/concurrent/futures/_base.py", line 340, in _invoke_callbacks
Mar 27 16:17:34 neon ovos_PHAL[2219]:     callback(self)
Mar 27 16:17:34 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/pyee/_executor.py", line 57, in _callback
Mar 27 16:17:34 neon ovos_PHAL[2219]:     self.emit("error", exc)
Mar 27 16:17:34 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/pyee/_base.py", line 118, in emit
Mar 27 16:17:34 neon ovos_PHAL[2219]:     self._emit_handle_potential_error(event, args[0] if args else None)
Mar 27 16:17:34 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/pyee/_base.py", line 88, in _emit_handle_potential_error
Mar 27 16:17:34 neon ovos_PHAL[2219]:     raise error
Mar 27 16:17:34 neon ovos_PHAL[2219]:   File "/usr/lib/python3.11/concurrent/futures/thread.py", line 58, in run
Mar 27 16:17:34 neon ovos_PHAL[2219]:     result = self.fn(*self.args, **self.kwargs)
Mar 27 16:17:34 neon ovos_PHAL[2219]:              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Mar 27 16:17:34 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/ovos_PHAL_plugin_wallpaper_manager/__init__.py", line 309, in handle_change_wallpaper
Mar 27 16:17:34 neon ovos_PHAL[2219]:     self.handle_set_wallpaper(Message("ovos.wallpaper.manager.set.wallpaper",
Mar 27 16:17:34 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/ovos_PHAL_plugin_wallpaper_manager/__init__.py", line 281, in handle_set_wallpaper
Mar 27 16:17:34 neon ovos_PHAL[2219]:     set_wallpaper(wallpaper)
Mar 27 16:17:34 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/wallpaper_changer/__init__.py", line 20, in set_wallpaper
Mar 27 16:17:34 neon ovos_PHAL[2219]:     desktop_env = desktop_env or get_desktop_environment()
Mar 27 16:17:34 neon ovos_PHAL[2219]:                                  ^^^^^^^^^^^^^^^^^^^^^^^^^
Mar 27 16:17:34 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/wallpaper_changer/__init__.py", line 188, in get_desktop_environment
Mar 27 16:17:34 neon ovos_PHAL[2219]:     elif is_running("xfce-mcs-manage"):
Mar 27 16:17:34 neon ovos_PHAL[2219]:          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Mar 27 16:17:34 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/wallpaper_changer/__init__.py", line 149, in is_running
Mar 27 16:17:34 neon ovos_PHAL[2219]:     if re.search(process, x):
Mar 27 16:17:34 neon ovos_PHAL[2219]:        ^^^^^^^^^^^^^^^^^^^^^
Mar 27 16:17:34 neon ovos_PHAL[2219]:   File "/usr/lib/python3.11/re/__init__.py", line 176, in search
Mar 27 16:17:34 neon ovos_PHAL[2219]:     return _compile(pattern, flags).search(string)
Mar 27 16:17:34 neon ovos_PHAL[2219]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Mar 27 16:17:34 neon ovos_PHAL[2219]: TypeError: cannot use a string pattern on a bytes-like object
Mar 27 16:17:35 neon ovos_PHAL[2219]: exception calling callback for <Future at 0x7f9caeb650 state=finished raised TypeError>
Mar 27 16:17:35 neon ovos_PHAL[2219]: Traceback (most recent call last):
Mar 27 16:17:35 neon ovos_PHAL[2219]:   File "/usr/lib/python3.11/concurrent/futures/_base.py", line 340, in _invoke_callbacks
Mar 27 16:17:35 neon ovos_PHAL[2219]:     callback(self)
Mar 27 16:17:35 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/pyee/_executor.py", line 57, in _callback
Mar 27 16:17:35 neon ovos_PHAL[2219]:     self.emit("error", exc)
Mar 27 16:17:35 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/pyee/_base.py", line 118, in emit
Mar 27 16:17:35 neon ovos_PHAL[2219]:     self._emit_handle_potential_error(event, args[0] if args else None)
Mar 27 16:17:35 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/pyee/_base.py", line 88, in _emit_handle_potential_error
Mar 27 16:17:35 neon ovos_PHAL[2219]:     raise error
Mar 27 16:17:35 neon ovos_PHAL[2219]:   File "/usr/lib/python3.11/concurrent/futures/thread.py", line 58, in run
Mar 27 16:17:35 neon ovos_PHAL[2219]:     result = self.fn(*self.args, **self.kwargs)
Mar 27 16:17:35 neon ovos_PHAL[2219]:              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Mar 27 16:17:35 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/ovos_PHAL_plugin_wallpaper_manager/__init__.py", line 309, in handle_change_wallpaper
Mar 27 16:17:35 neon ovos_PHAL[2219]:     self.handle_set_wallpaper(Message("ovos.wallpaper.manager.set.wallpaper",
Mar 27 16:17:35 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/ovos_PHAL_plugin_wallpaper_manager/__init__.py", line 281, in handle_set_wallpaper
Mar 27 16:17:35 neon ovos_PHAL[2219]:     set_wallpaper(wallpaper)
Mar 27 16:17:35 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/wallpaper_changer/__init__.py", line 20, in set_wallpaper
Mar 27 16:17:35 neon ovos_PHAL[2219]:     desktop_env = desktop_env or get_desktop_environment()
Mar 27 16:17:35 neon ovos_PHAL[2219]:                                  ^^^^^^^^^^^^^^^^^^^^^^^^^
Mar 27 16:17:35 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/wallpaper_changer/__init__.py", line 188, in get_desktop_environment
Mar 27 16:17:35 neon ovos_PHAL[2219]:     elif is_running("xfce-mcs-manage"):
Mar 27 16:17:35 neon ovos_PHAL[2219]:          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Mar 27 16:17:35 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/wallpaper_changer/__init__.py", line 149, in is_running
Mar 27 16:17:35 neon ovos_PHAL[2219]:     if re.search(process, x):
Mar 27 16:17:35 neon ovos_PHAL[2219]:        ^^^^^^^^^^^^^^^^^^^^^
Mar 27 16:17:35 neon ovos_PHAL[2219]:   File "/usr/lib/python3.11/re/__init__.py", line 176, in search
Mar 27 16:17:35 neon ovos_PHAL[2219]:     return _compile(pattern, flags).search(string)
Mar 27 16:17:35 neon ovos_PHAL[2219]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Mar 27 16:17:35 neon ovos_PHAL[2219]: TypeError: cannot use a string pattern on a bytes-like object
Mar 27 16:17:40 neon ovos_PHAL[2219]: exception calling callback for <Future at 0x7f9cae9550 state=finished raised TypeError>
Mar 27 16:17:40 neon ovos_PHAL[2219]: Traceback (most recent call last):
Mar 27 16:17:40 neon ovos_PHAL[2219]:   File "/usr/lib/python3.11/concurrent/futures/_base.py", line 340, in _invoke_callbacks
Mar 27 16:17:40 neon ovos_PHAL[2219]:     callback(self)
Mar 27 16:17:40 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/pyee/_executor.py", line 57, in _callback
Mar 27 16:17:40 neon ovos_PHAL[2219]:     self.emit("error", exc)
Mar 27 16:17:40 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/pyee/_base.py", line 118, in emit
Mar 27 16:17:40 neon ovos_PHAL[2219]:     self._emit_handle_potential_error(event, args[0] if args else None)
Mar 27 16:17:40 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/pyee/_base.py", line 88, in _emit_handle_potential_error
Mar 27 16:17:40 neon ovos_PHAL[2219]:     raise error
Mar 27 16:17:40 neon ovos_PHAL[2219]:   File "/usr/lib/python3.11/concurrent/futures/thread.py", line 58, in run
Mar 27 16:17:40 neon ovos_PHAL[2219]:     result = self.fn(*self.args, **self.kwargs)
Mar 27 16:17:40 neon ovos_PHAL[2219]:              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Mar 27 16:17:40 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/ovos_PHAL_plugin_wallpaper_manager/__init__.py", line 309, in handle_change_wallpaper
Mar 27 16:17:40 neon ovos_PHAL[2219]:     self.handle_set_wallpaper(Message("ovos.wallpaper.manager.set.wallpaper",
Mar 27 16:17:40 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/ovos_PHAL_plugin_wallpaper_manager/__init__.py", line 281, in handle_set_wallpaper
Mar 27 16:17:40 neon ovos_PHAL[2219]:     set_wallpaper(wallpaper)
Mar 27 16:17:40 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/wallpaper_changer/__init__.py", line 20, in set_wallpaper
Mar 27 16:17:40 neon ovos_PHAL[2219]:     desktop_env = desktop_env or get_desktop_environment()
Mar 27 16:17:40 neon ovos_PHAL[2219]:                                  ^^^^^^^^^^^^^^^^^^^^^^^^^
Mar 27 16:17:40 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/wallpaper_changer/__init__.py", line 188, in get_desktop_environment
Mar 27 16:17:40 neon ovos_PHAL[2219]:     elif is_running("xfce-mcs-manage"):
Mar 27 16:17:40 neon ovos_PHAL[2219]:          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Mar 27 16:17:40 neon ovos_PHAL[2219]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/wallpaper_changer/__init__.py", line 149, in is_running
Mar 27 16:17:40 neon ovos_PHAL[2219]:     if re.search(process, x):
Mar 27 16:17:40 neon ovos_PHAL[2219]:        ^^^^^^^^^^^^^^^^^^^^^
Mar 27 16:17:40 neon ovos_PHAL[2219]:   File "/usr/lib/python3.11/re/__init__.py", line 176, in search
Mar 27 16:17:40 neon ovos_PHAL[2219]:     return _compile(pattern, flags).search(string)
Mar 27 16:17:40 neon ovos_PHAL[2219]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Mar 27 16:17:40 neon ovos_PHAL[2219]: TypeError: cannot use a string pattern on a bytes-like object

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.