OpenVoiceOS / OpenVoiceOS/raspOVOS

Improve file upload security and error handling in ovos-support script

Open
#131 0 comments 0 reactions 1 assignee View on GitHub

@JarbasAl is already working on this.

Since Jan 18, 2025.

Dominant language
Shell
Stars
52
Forks
6
No merged PRs in 30d

Description

Security improvements needed for the file upload functionality in ovos-support script:

  1. Add user confirmation prompt before upload to allow inspection of potentially sensitive data
  2. Add proper verification of upload success by checking HTTP status code
  3. Add error handling for curl failures and network issues
  4. Extract response body and status code separately for better error reporting

Related PR: #129
Related comment: https://github.com/OpenVoiceOS/raspOVOS/pull/129#discussion_r1920938184

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.