OpenVoiceOS / OpenVoiceOS/ovos-workshop
Incomplete OCP keyword deregistration functionality in OVOSCommonPlaybackSkill
Open
@JarbasAl is already working on this.
Since Jul 8, 2025.
- Dominant language
- Python
- Stars
- 6
- Forks
- 17
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 36
Description
Problem
The deregister_ocp_keyword method in OVOSCommonPlaybackSkill is currently incomplete and does not properly remove entities from internal data structures (ocp_matchers and _ocp_ents). This could lead to memory leaks as entities accumulate without proper cleanup.
Current Behavior
The method currently only passes without removing entities:
- Entities remain in
ocp_matchersdictionary - Entities remain in
_ocp_entsdictionary - No local cleanup is performed
Expected Behavior
The method should properly clean up registered entities from internal data structures, even if upstream deregistration is not yet supported.
Context
This issue was identified during code review of PR #365.
References:
- PR: https://github.com/OpenVoiceOS/ovos-workshop/pull/365
- Comment: https://github.com/OpenVoiceOS/ovos-workshop/pull/365#discussion_r2193045584
- Requested by: @JarbasAl
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.