OpenVoiceOS / OpenVoiceOS/ovos-workshop
Improve CSV parsing in load_ocp_keyword_from_csv method
Open
@JarbasAl is already working on this.
Since Jul 8, 2025.
- Dominant language
- Python
- Stars
- 6
- Forks
- 17
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 36
Description
Description
The current implementation of load_ocp_keyword_from_csv method in ovos_workshop/skills/common_play.py uses manual CSV parsing which has several limitations:
- Cannot handle quoted fields or commas within values
- No error handling for malformed lines
- Uses ambiguous variable name
Suggested Improvement
Replace the manual CSV parsing with Python's built-in csv module for robust CSV handling with proper error handling and support for quoted fields.
Context
This issue was identified during code review of PR #365.
Related Links:
- PR: https://github.com/OpenVoiceOS/ovos-workshop/pull/365
- Comment: https://github.com/OpenVoiceOS/ovos-workshop/pull/365#discussion_r2192886329
- Requested by: @JarbasAl
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.