OpenVoiceOS / OpenVoiceOS/ovos-workshop
settings changed decorator
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Python
- Stars
- 6
- Forks
- 17
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 36
Description
we should add a decorator for skill settings, instead of the current way
def initialize(self):
self.settings_change_callback = self.on_settings_changed
this would make the code more readable and help avoiding user mistakes (such as assigning the callback before the call to super)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the skill settings implementation and the initialize method that assigns settings_change_callback. Determine how a decorator could replace that assignment while preserving the callback behavior and avoiding ordering mistakes around super. Done means the decorator is supported and the existing callback pattern is no longer required.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- developer-experience
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100