OpenVoiceOS / OpenVoiceOS/ovos-utils
Improve error handling when all template lines fail to expand
@JarbasAl is already working on this.
Since Dec 6, 2024.
- Dominant language
- Python
- Stars
- 6
- Forks
- 13
- Avg merge
- 1d 8m
- Merged PRs (30d)
- 8
Description
When all lines fail to expand during template rendering, an exception should be thrown. If at least one line expands successfully, failed lines should be logged and ignored, allowing processing to continue.
PR: https://github.com/OpenVoiceOS/ovos-utils/pull/317
Comment: https://github.com/OpenVoiceOS/ovos-utils/pull/317#discussion_r1872397809
Requester: @JarbasAl
Learning: In ovos_utils/dialog.py, when all lines in a template fail to expand during rendering, an exception should be thrown. If at least one line expands successfully, any failed lines should be logged, the bad lines dropped, and processing should continue since there is enough data to proceed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.