OpenVoiceOS / OpenVoiceOS/ovos-utils

Dependabot does not install the extras extra

Open
#226 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
6
Forks
13
Avg merge
1d 8m
Merged PRs (30d)
8

Description

rapidfuzz was upgraded to a significantly higher version, which drops compatibility with 3.7. The Dependabot PR didn't catch that because it's doesn't run unit tests, and the build tests try to install the [all] extra (which doesn't exist).

Identified in unit tests on this PR: https://github.com/OpenVoiceOS/ovos-utils/actions/runs/7721017873/job/21046877080

I'm also not sure pinning to a version that new is a good idea when there were no compatibility issues with the older version - I do see some good-sized vulnerability fixes there though.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Dependabot and unit-test workflow runs, then inspect the build configuration that requests the nonexistent [all] extra. Reproduce the rapidfuzz upgrade failure and determine how the dependency and CI test paths should behave. Done means the dependency update is tested and the extra installation no longer fails.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, python
Domain
build-system, ci-cd, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.