OpenVoiceOS / OpenVoiceOS/ovos-plugin-manager

Fallback for online services

Open
#312 4 comments 3 reactions 2 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
14
Forks
14
Avg merge
2d 19h
Merged PRs (30d)
9

Description

Dear all,
what you are doing is amazing. I have been thinking of the cases when you hit a fallback for STT and TTS services and I think it could be an improvement to change the way fallbacks are declared. At the moment we have:

module: "",
fallback-module: ""

this case is working fine, but it is limiting because, for example, it forces the user to choose to run the fallback as local or remote service when the case to hit a fallback can be multiple.

For example, I finish my tokens in my remote service TTS , so my main service fail and I hit the fallback that could be, for example, another account with the same service or another online service. However, I could also be in the situation where I have a very limited or no connection and thus my fallback should be an offline service.

A possible solution can be to define the services differently like an ordered list:

module: [
  - online_service1,
  - online_service2,
  - offline_service
]

With this configuration, if I do not have internet, the modules keep failing until starting the offline service.

just an idea.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.