OpenVoiceOS / OpenVoiceOS/ovos-plugin-manager

Streaming TTS is only usable with paplay

Open
#218 0 comments 0 reactions 1 assignee View on GitHub

@JarbasAl is already working on this.

Since May 17, 2024.

bug
Dominant language
Python
Stars
14
Forks
14
Avg merge
2d 19h
Merged PRs (30d)
9

Description

https://github.com/OpenVoiceOS/ovos-plugin-manager/blob/8244ec591f95c950a1fe7309e4c516faa5206e3e/ovos_plugin_manager/templates/tts.py#L821

In the above code, play_args can override the default of ["paplay"], but it comes from the __init__() kwargs. Since self.config can't be accessed in a plugin until super().__init__() is called, it's not possible to pass this configuration from a plugin config.

Ideally the default would be the global player instead of hardcoded paplay to allow for other playback systems

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.