OpenVoiceOS / OpenVoiceOS/ovos-plugin-manager

[BUG] Skills failing to load due to issues in setup.py do not log exceptions

Open
#216 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
14
Forks
13
Avg merge
2d 19h
Merged PRs (30d)
9

Description

When developing skills and experimenting with different packaging, or with the projen skill generator, sometimes I'll make changes to setup.py to test something and fail. When this happens my skill fails to load but doesn't give me anything in the OVOS logs as to why. I do get those logs when I pop a REPL and instantiate my skill class (or do it in my IDE).

This leads to a poor developer experience, as it's not intuitive at all for someone unfamiliar with how OVOS handles skill loading. Acceptance criteria would be logging those exceptions in OVOS when a skill fails to load properly.

[JarbasAI]
LOG.exception will print them
probably somewhere in the loading of skills isnt doing this and should

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the skill-loading path in ovos-plugin-manager and reproduce a load failure caused by an invalid setup.py. Compare this with instantiating the skill in a REPL, where the exception is visible, and identify where LOG.exception is missing. Done means setup.py-related skill-load exceptions appear in the OVOS logs.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, developer-experience
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.