OpenVoiceOS / OpenVoiceOS/ovos-number-parser

Spoken ordinal numbers not extracted correctly (in German)

Open
#17 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug help wanted
Dominant language
Python
Stars
4
Forks
5
Avg merge
4d 22h
Merged PRs (30d)
2

Description

>>> a = "nimm den siebten eintrag"
>>> b = ovos_number_parser.extract_number_de(a)
>>> b
>>> 

Maybe not all grammatical variants are considered...

Further examples (using strings from module source code):

>>> a = "nimm den siebt eintrag"
>>> b = ovos_number_parser.extract_number_de(a)
>>> print(b)
>>> None

In English a bit different, may help:

>>> a = "take second row"
>>> b = ovos_number_parser.extract_number_en(a)
>>> print(b)
>>> False

Noticeable that in German it is 'None' and in English 'False'

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the module source code and the extract_number_de and extract_number_en entry points, then reproduce the German and English examples from the issue. Compare how ordinal variants are recognized; the work is done when the reported German forms are extracted consistently with the intended result and the behavior is covered by the relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
localization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.