OpenVoiceOS / OpenVoiceOS/ovos-microphone-plugin-alsa

stuck while shutting down

Open
#4 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
0
Forks
4
PR merge metrics
No merged PRs in 30d

Description

2023-09-18 22:48:07.754 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:261 - INFO - Loop stopped running
2023-09-18 22:48:07.758 - voice - ovos_dinkum_listener.service:on_stopping:68 - INFO - DinkumVoiceService is shutting down...
2023-09-18 22:48:07.761 - voice - ovos_dinkum_listener.service:run:279 - INFO - Service stopping
2023-09-18 22:48:37.672 - voice - ovos_dinkum_listener.service:stop:346 - ERROR - voice_loop didn't call _shutdown
-----------Keyboard Interrupt--------
Traceback (most recent call last):
  File "/home/ovos/.local/bin/ovos-dinkum-listener", line 8, in <module>
2023-09-18 22:50:22.220 - voice - ovos_dinkum_listener.service:run:281 - DEBUG - shutdown done
2023-09-18 22:50:22.225 - voice - ovos_dinkum_listener.service:run:283 - DEBUG - stopped
    sys.exit(main())
  File "/home/ovos/.local/lib/python3.10/site-packages/ovos_dinkum_listener/__main__.py", line 29, in main
    service.stop()
  File "/home/ovos/.local/lib/python3.10/site-packages/ovos_dinkum_listener/service.py", line 347, in stop
    self._shutdown()
  File "/home/ovos/.local/lib/python3.10/site-packages/ovos_dinkum_listener/service.py", line 369, in _shutdown
    self.mic.stop()
  File "/home/ovos/.local/lib/python3.10/site-packages/ovos_microphone_plugin_alsa/__init__.py", line 55, in stop
    self._thread.join()
  File "/usr/lib/python3.10/threading.py", line 1096, in join
    self._wait_for_tstate_lock()
  File "/usr/lib/python3.10/threading.py", line 1116, in _wait_for_tstate_lock
    if lock.acquire(block, timeout):
KeyboardInterrupt

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the shutdown path shown in ovos_dinkum_listener/service.py, especially stop() and _shutdown(), then inspect ovos_microphone_plugin_alsa/init.py at stop() and the thread join. Reproduce the shutdown interruption and determine what must change so the service exits without hanging in microphone shutdown.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
audio-video-rtc
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.