OpenVoiceOS / OpenVoiceOS/ovos-gui
QT6 support maybe
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3
- Forks
- 5
- Avg merge
- 5d 10h
- Merged PRs (30d)
- 2
Description
we can do better here maybe...
- mycroft-gui sends a GuiID on connection, the proper fix would be to emit this to the correct gui bus instead
- the handler should LOG a legacy gui deprecation warning
- we can try to map this gui id to the clients singleton
- unfortunately GuiID is not sent in any follow up requests to the actual gui socket, only on the original message.... this should be fixed mycroft-gui side, this should likely be sent with every request as context from mycroft-gui side, but if a PR is accepted there then it should just fix the initial message / send the framework context properly, this hack is only needed assuming no PRs are accepted....
- when a gui connects, we can loop trough clients list, filter the clients without a platform, and if there is only one (as it should be most of the time) we can assign the framework received in legacy handler
Originally posted by @JarbasAl in https://github.com/OpenVoiceOS/ovos-gui/pull/9#discussion_r1254866552
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the handler in ovos_gui/namespace.py around line 860 and the clients singleton in ovos_gui/bus.py around line 98. Compare these with the GuiID connection handling in mycroftcontroller.cpp around line 74. Done should be defined by a decided approach for carrying the GUI framework or identifier through the connection and follow-up requests, including the legacy warning behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, python
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100